perf: remove dotenv dependency and use custom parse function#5379
Merged
chenjiahan merged 2 commits intomainfrom Jun 7, 2025
Merged
perf: remove dotenv dependency and use custom parse function#5379chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the environment loading logic by replacing the dotenv dependency with a custom parse function to reduce the output bundle size.
- Removed the dotenv dependency and its associated import.
- Introduced a custom parse function to handle .env file parsing.
- Updated package.json to reflect the removal of the unused dependency.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/loadEnv.ts | Replaced dotenv’s parse method with a custom implementation. |
| packages/core/package.json | Removed the dotenv dependency to reduce bundle size. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/core/src/loadEnv.ts:19
- Ensure that the custom parse function is thoroughly covered by tests to validate its behavior against various .env file edge cases.
function parse(src: Buffer) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request replaces the
dotenvdependency with a custom implementation of itsparsemethod to reduce unused functionality.Removed the following lines from the output bundle:
Related Links
https://github.com/motdotla/dotenv/blob/v16.5.0/lib/main.js#L9-L48
Checklist